Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node selectors and improved affinity options #86

Merged
merged 11 commits into from
Nov 29, 2024
Merged

Node selectors and improved affinity options #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7dc44ff
Init node selectors.
antejavor Nov 27, 2024
6fe019f
Update values.
antejavor Nov 27, 2024
c5e0a92
Delete parity soft.
antejavor Nov 27, 2024
211cead
Update.
antejavor Nov 27, 2024
b364ad8
Update messaging.
antejavor Nov 27, 2024
905ef22
Update config.
antejavor Nov 27, 2024
a24e68f
Merge branch 'main' into add-node-selectors
antejavor Nov 28, 2024
14c94bd
Fix values.
antejavor Nov 28, 2024
0ca8087
Fix indent.
antejavor Nov 28, 2024
ac5f51d
Fix default option.
antejavor Nov 28, 2024
3b6d2a1
Remove affinity option.
antejavor Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 41 additions & 48 deletions charts/memgraph-high-availability/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,62 +20,55 @@ Or you can modify a `values.yaml` file and override the desired values:
helm install <release-name> memgraph/memgraph-high-availability -f values.yaml
```

## Running the Memgraph HA Helm Chart locally

To run Memgraph HA Helm Chart locally, affinity needs to be disabled because the cluster will be running on a single node.

To disable the affinity, run the following command with the specified set of flags:

```
helm install <release-name> memgraph/memgraph-high-availability --set memgraph.env.MEMGRAPH_ENTERPRISE_LICENSE=<your-license>,memgraph.env.MEMGRAPH_ORGANIZATION_NAME=<your-organization-name>,memgraph.affinity.enabled=false
```

The affinity is disabled either by running the command above, or by modifying the `values.yaml` file.


## Configuration Options

The following table lists the configurable parameters of the Memgraph chart and their default values.


| Parameter | Description | Default |
|---------------------------------------------|-----------------------------------------------------------------------------------------------------|-----------------------------------------|
| `memgraph.image.repository` | Memgraph Docker image repository | `memgraph/memgraph` |
| `memgraph.image.tag` | Specific tag for the Memgraph Docker image. Overrides the image tag whose default is chart version. | `2.22.0` |
| `memgraph.image.pullPolicy` | Image pull policy | `IfNotPresent` |
| `memgraph.env.MEMGRAPH_ENTERPRISE_LICENSE` | Memgraph enterprise license | `<your-license>` |
| `memgraph.env.MEMGRAPH_ORGANIZATION_NAME` | Organization name | `<your-organization-name>` |
| `memgraph.probes.startup.failureThreshold` | Startup probe failure threshold | `30` |
| `memgraph.probes.startup.periodSeconds` | Startup probe period in seconds | `10` |
| `memgraph.probes.readiness.initialDelaySeconds` | Readiness probe initial delay in seconds | `5` |
| `memgraph.probes.readiness.periodSeconds` | Readiness probe period in seconds | `5` |
| `memgraph.probes.liveness.initialDelaySeconds` | Liveness probe initial delay in seconds | `30` |
| `memgraph.probes.liveness.periodSeconds` | Liveness probe period in seconds | `10` |
| `memgraph.data.volumeClaim.storagePVC` | Enable storage PVC | `true` |
| `memgraph.data.volumeClaim.storagePVCSize` | Size of the storage PVC | `1Gi` |
| `memgraph.data.volumeClaim.logPVC` | Enable log PVC | `false` |
| `memgraph.data.volumeClaim.logPVCSize` | Size of the log PVC | `256Mi` |
| `memgraph.coordinators.volumeClaim.storagePVC` | Enable storage PVC for coordinators | `true` |
| `memgraph.coordinators.volumeClaim.storagePVCSize` | Size of the storage PVC for coordinators | `1Gi` |
| `memgraph.coordinators.volumeClaim.logPVC` | Enable log PVC for coordinators | `false` |
| `memgraph.coordinators.volumeClaim.logPVCSize` | Size of the log PVC for coordinators | `256Mi` |
| `memgraph.affinity.enabled` | Enables affinity so each instance is deployed to unique node | `true` |
| `memgraph.externalAccess.serviceType` | NodePort or LoadBalancer. Use LoadBalancer for Cloud production deployment and NodePort for local testing | `LoadBalancer` |
| `memgraph.ports.boltPort` | Bolt port used on coordinator and data instances. | `7687` |
| `memgraph.ports.managementPort` | Management port used on coordinator and data instances. | `10000` |
| `memgraph.ports.replicationPort` | Replication port used on data instances. | `20000` |
| `memgraph.ports.coordinatorPort` | Coordinator port used on coordinators. | `12000` |
| `data` | Configuration for data instances | See `data` section |
| `coordinators` | Configuration for coordinator instances | See `coordinators` section |
| `sysctlInitContainer.enabled` | Enable the init container to set sysctl parameters | `true` |
| `sysctlInitContainer.maxMapCount` | Value for `vm.max_map_count` to be set by the init container | `262144` |
| Parameter | Description | Default |
| -------------------------------------------------- | --------------------------------------------------------------------------------------------------------- | -------------------------- |
| `memgraph.image.repository` | Memgraph Docker image repository | `memgraph/memgraph` |
| `memgraph.image.tag` | Specific tag for the Memgraph Docker image. Overrides the image tag whose default is chart version. | `2.22.0` |
| `memgraph.image.pullPolicy` | Image pull policy | `IfNotPresent` |
| `memgraph.env.MEMGRAPH_ENTERPRISE_LICENSE` | Memgraph enterprise license | `<your-license>` |
| `memgraph.env.MEMGRAPH_ORGANIZATION_NAME` | Organization name | `<your-organization-name>` |
| `memgraph.probes.startup.failureThreshold` | Startup probe failure threshold | `30` |
| `memgraph.probes.startup.periodSeconds` | Startup probe period in seconds | `10` |
| `memgraph.probes.readiness.initialDelaySeconds` | Readiness probe initial delay in seconds | `5` |
| `memgraph.probes.readiness.periodSeconds` | Readiness probe period in seconds | `5` |
| `memgraph.probes.liveness.initialDelaySeconds` | Liveness probe initial delay in seconds | `30` |
| `memgraph.probes.liveness.periodSeconds` | Liveness probe period in seconds | `10` |
| `memgraph.data.volumeClaim.storagePVC` | Enable storage PVC | `true` |
| `memgraph.data.volumeClaim.storagePVCSize` | Size of the storage PVC | `1Gi` |
| `memgraph.data.volumeClaim.logPVC` | Enable log PVC | `false` |
| `memgraph.data.volumeClaim.logPVCSize` | Size of the log PVC | `256Mi` |
| `memgraph.coordinators.volumeClaim.storagePVC` | Enable storage PVC for coordinators | `true` |
| `memgraph.coordinators.volumeClaim.storagePVCSize` | Size of the storage PVC for coordinators | `1Gi` |
| `memgraph.coordinators.volumeClaim.logPVC` | Enable log PVC for coordinators | `false` |
| `memgraph.coordinators.volumeClaim.logPVCSize` | Size of the log PVC for coordinators | `256Mi` |
| `memgraph.externalAccess.serviceType` | NodePort or LoadBalancer. Use LoadBalancer for Cloud production deployment and NodePort for local testing | `LoadBalancer` |
| `memgraph.ports.boltPort` | Bolt port used on coordinator and data instances. | `7687` |
| `memgraph.ports.managementPort` | Management port used on coordinator and data instances. | `10000` |
| `memgraph.ports.replicationPort` | Replication port used on data instances. | `20000` |
| `memgraph.ports.coordinatorPort` | Coordinator port used on coordinators. | `12000` |
| `memgraph.affinity.unique` | Schedule pods on different nodes in the cluster | `false` |
| `memgraph.affinity.parity` | Schedule pods on the same node with maximum one coordinator and one data node | `false` |
| `memgraph.affinity.nodeSelection` | Schedule pods on nodes with specific labels | `false` |
| `memgraph.affinity.roleLabelKey` | Label key for node selection | `role` |
| `memgraph.affinity.dataNodeLabelValue` | Label value for data nodes | `data-node` |
| `memgraph.affinity.coordinatorNodeLabelValue` | Label value for coordinator nodes | `coordinator-node` |
| `data` | Configuration for data instances | See `data` section |
| `coordinators` | Configuration for coordinator instances | See `coordinators` section |
| `sysctlInitContainer.enabled` | Enable the init container to set sysctl parameters | `true` |
| `sysctlInitContainer.maxMapCount` | Value for `vm.max_map_count` to be set by the init container | `262144` |

For the `data` and `coordinators` sections, each item in the list has the following parameters:

| Parameter | Description | Default |
|---------------------------------------------|-----------------------------------------------------------------------------------------------------|-----------------------------------------|
| `id` | ID of the instance | `0` for data, `1` for coordinators |
| `args` | List of arguments for the instance | See `args` section |
| Parameter | Description | Default |
| --------- | ---------------------------------- | ---------------------------------- |
| `id` | ID of the instance | `0` for data, `1` for coordinators |
| `args` | List of arguments for the instance | See `args` section |



The `args` section contains a list of arguments for the instance. The default values are the same for all instances:
Expand Down
60 changes: 52 additions & 8 deletions charts/memgraph-high-availability/templates/coordinators.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,72 @@ spec:
selector:
matchLabels:
app: memgraph-coordinator-{{ $coordinator.id }}
role: coordinator
template:
metadata:
labels:
app: memgraph-coordinator-{{ $coordinator.id }}
role: coordinator
as51340 marked this conversation as resolved.
Show resolved Hide resolved
instance-type: coordinator

spec:
{{ if $.Values.memgraph.affinity.enabled }}
affinity:
{{- if $.Values.memgraph.affinity.nodeSelection }}
# Node Selection Affinity: Scheduled on nodes with specific label key and value
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: {{ $.Values.memgraph.affinity.roleLabelKey }}
operator: In
values:
- {{ $.Values.memgraph.affinity.coordinatorNodeLabelValue }}
podAntiAffinity :
requiredDuringSchedulingIgnoredDuringExecution:
- labelSelector:
matchExpressions:
- key: role
operator: In
values:
- coordinator
as51340 marked this conversation as resolved.
Show resolved Hide resolved
topologyKey: "kubernetes.io/hostname"
{{- else if $.Values.memgraph.affinity.unique }}
as51340 marked this conversation as resolved.
Show resolved Hide resolved
# Unique Affinity: Schedule pods on different nodes
podAntiAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
- labelSelector:
matchExpressions:
- key: app
- key: role
operator: In
values:
- memgraph-coordinator-1
- memgraph-coordinator-2
- memgraph-coordinator-3
- memgraph-data-0
- memgraph-data-1
- coordinator
- data
topologyKey: "kubernetes.io/hostname"
{{ end }}
{{- else if $.Values.memgraph.affinity.parity }}
# Parity Affinity: One coordinator and one data node per node, coordinator schedules first, needs to be in pairs
podAntiAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
- labelSelector:
matchExpressions:
- key: role
operator: In
values:
- coordinator
topologyKey: "kubernetes.io/hostname"
{{- else }}
# Default Affinity: Avoid scheduling on the same node
podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
as51340 marked this conversation as resolved.
Show resolved Hide resolved
- weight: 50
podAffinityTerm:
labelSelector:
matchExpressions:
- key: role
operator: In
values:
- coordinator
as51340 marked this conversation as resolved.
Show resolved Hide resolved
as51340 marked this conversation as resolved.
Show resolved Hide resolved
topologyKey: "kubernetes.io/hostname"
{{- end }}
initContainers:
- name: init
image: "{{ $.Values.memgraph.image.repository }}:{{ $.Values.memgraph.image.tag }}"
Expand Down
Loading
Loading