Add default storage class and retain policy #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as51340
requested changes
Nov 27, 2024
This was referenced Nov 28, 2024
|
@antejavor But it's literally adding one file, what do we get by postponing it to next release. You want someone to try it or, what's the reason? |
as51340
approved these changes
Nov 29, 2024
|
Yeah, I would like to test different environments with standalone and then move to HA for different environments since it is easier and less expensive to test with standalone than with HA cluster @as51340 As discussed on the call, let's do this in the next release to push this release as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a storage class with the
Retainpolicy. Both lib and log storage will use dynamic storage class without the retain policy because of CI/CD and local development (minikube). For production deployments in AWS, Azure, and GCP, defaults need to change.