Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update secrets naming #56

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Update secrets naming #56

merged 6 commits into from
Aug 14, 2024

Conversation

antejavor
Copy link
Collaborator

@antejavor antejavor commented Aug 13, 2024 •
edited
Loading

Due to confusion with ENVs, I have renamed the keys to USER and PASSWORD.

Context: memgraph/documentation#960

@antejavor antejavor marked this pull request as ready for review August 13, 2024 10:20
as51340
as51340 requested changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

charts/memgraph/README.md Show resolved Hide resolved
@antejavor antejavor requested a review from as51340 August 13, 2024 11:14
@antejavor antejavor merged commit ad0b6d0 into main Aug 14, 2024
2 checks passed
@antejavor antejavor deleted the fix-naming branch November 7, 2024 14:34
as51340 pushed a commit that referenced this pull request Dec 2, 2024
@antejavor
Update secrets naming (#56)
e26772d 
Updated secrets naming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@as51340 as51340 as51340 approved these changes

@katarinasupe katarinasupe Awaiting requested review from katarinasupe katarinasupe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antejavor @as51340