Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HA affinity #55

Merged
merged 4 commits into from
Aug 14, 2024
Merged

HA affinity #55

merged 4 commits into from
Aug 14, 2024

Conversation

antejavor
Copy link
Collaborator

@antejavor antejavor commented Aug 12, 2024 •
edited
Loading

Add affinity to HA chart.

Before:

NAME                       READY   STATUS      RESTARTS   AGE   IP               NODE                                          NOMINATED NODE   READINESS GATES
memgraph-coordinator-1-0   1/1     Running     0          42s   192.168.85.135   ip-192-168-70-79.eu-west-1.compute.internal   <none>           <none>
memgraph-coordinator-2-0   1/1     Running     0          42s   192.168.94.105   ip-192-168-70-79.eu-west-1.compute.internal   <none>           <none>
memgraph-coordinator-3-0   1/1     Running     0          42s   192.168.87.250   ip-192-168-70-79.eu-west-1.compute.internal   <none>           <none>
memgraph-data-0-0          1/1     Running     0          42s   192.168.73.27    ip-192-168-70-79.eu-west-1.compute.internal   <none>           <none>
memgraph-data-1-0          1/1     Running     0          42s   192.168.79.90    ip-192-168-70-79.eu-west-1.compute.internal   <none>           <none>
memgraph-setup-b696j       0/1     Completed   0          42s   192.168.69.225   ip-192-168-70-79.eu-west-1.compute.internal   <none>           <none>

After:

NAME                       READY   STATUS     RESTARTS   AGE   IP               NODE                                           NOMINATED NODE   READINESS GATES
memgraph-coordinator-1-0   0/1     Init:0/1   0          17s   192.168.59.142   ip-192-168-41-31.eu-west-1.compute.internal    <none>           <none>
memgraph-coordinator-2-0   1/1     Running    0          17s   192.168.91.214   ip-192-168-88-220.eu-west-1.compute.internal   <none>           <none>
memgraph-coordinator-3-0   1/1     Running    0          17s   192.168.25.245   ip-192-168-25-138.eu-west-1.compute.internal   <none>           <none>
memgraph-data-0-0          1/1     Running    0          17s   192.168.93.177   ip-192-168-86-228.eu-west-1.compute.internal   <none>           <none>
memgraph-data-1-0          1/1     Running    0          17s   192.168.57.146   ip-192-168-60-0.eu-west-1.compute.internal     <none>           <none>
memgraph-setup-hn2dh       1/1     Running    0          17s   192.168.10.188   ip-192-168-25-138.eu-west-1.compute.internal   <none>           <none>

@antejavor antejavor self-assigned this Aug 12, 2024
@antejavor antejavor marked this pull request as ready for review August 12, 2024 16:29
as51340
as51340 requested changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just think that it should be enabled by default

charts/memgraph-high-availability/values.yaml Outdated
@@ -36,6 +36,8 @@ memgraph:
logPVCClassName: ""
logPVC: true
logPVCSize: "256Mi"
affinity:
enabled: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not true by default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set it up initially because the CI will fail, and you will need to pass the config each time in minikube, but I agree it should be true by default, will change this.

@antejavor antejavor requested a review from as51340 August 13, 2024 11:21
@antejavor antejavor merged commit d08e538 into main Aug 14, 2024
2 checks passed
@antejavor antejavor deleted the add-affinity-to-ha-chart branch November 7, 2024 14:34
as51340 pushed a commit that referenced this pull request Dec 2, 2024
@antejavor
HA affinity (#55)
d73a57c 
* Add affinity to HA chart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@as51340 as51340 as51340 approved these changes

@katarinasupe katarinasupe Awaiting requested review from katarinasupe katarinasupe is a code owner

Assignees

@antejavor antejavor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antejavor @as51340