Fix static number of volumes - fixes #11 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @hpdobrica, for your contribution! You're improving the Memgraph experience for our whole community 😄 We will review this PR as soon as possible and get back to you. |
antejavor
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
This PR includes updates to enable the increase of the replicate set value to more than 1.
It closes the following issue: #11
It also includes the updates to the README and closes #10.
The Memgraph version has been increased to the latest available 2.16.0
Thanks a lot for the initial push @hpdobrica 🦾 🥳
as51340
pushed a commit
that referenced
this pull request
Dec 2, 2024
* fix(storage): use volumeClaimTemplates instead of static PVCs - fixes #11 * feat(storage): enable specifying non-default storage class * delete the extra volume claims. * update README.md and bump up the version. --------- Co-authored-by: Ante Javor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there, in order to enable running multiple replicas, each with their own storage, i have:
note that this is likely a breaking change which will require reinstall of the chart and migration of data (old single volume was named
memgraph-lib-storage, new one would bememgraph-lib-storage-memgraph-$POD_NUMBER, as we are editing the volumeClaimTemplates field:i have also added the option to define a desired storage class to be used when creating the volumes.
this pr fixes #11