Add base path env (#84)

Add support to the helm chart that the base path does not stop the deployment of Lab.
memgraph · Nov 29, 2024 · c5fe0d2 · c5fe0d2
1 parent bb43336
commit c5fe0d2
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 14 deletions.
diff --git a/charts/memgraph-lab/Chart.yaml b/charts/memgraph-lab/Chart.yaml
@@ -3,10 +3,10 @@ name: memgraph-lab
 home: https://memgraph.com/
 type: application
 # Chart version, should be incremented each time the chart changes, including appVersion.
-version: 0.1.4
+version: 0.1.5
 # Version number of the docker image memgraph/lab.
 # Use it with quotes.
-appVersion: "2.18.1"
+appVersion: "2.19.1"
 description: Memgraph Lab Helm Chart
 keywords:
 - graph

diff --git a/charts/memgraph-lab/README.md b/charts/memgraph-lab/README.md
@@ -47,5 +47,7 @@ env:
     value: memgraph
   - name: QUICK_CONNECT_MG_PORT
     value: "7687"
+  - name: BASE_PATH
+    value: /
 ```
 Refer to the [Memgraph Lab documentation](https://memgraph.com/docs/data-visualization) for details on how to connect to and interact with Memgraph.
diff --git a/charts/memgraph-lab/templates/_helpers.tpl b/charts/memgraph-lab/templates/_helpers.tpl
@@ -60,3 +60,14 @@ Create the name of the service account to use
 {{- default "default" .Values.serviceAccount.name }}
 {{- end }}
 {{- end }}
+
+{{/*
+Get the base path env value
+*/}}
+{{- define "getBasePath" -}}
+{{- range .Values.env }}
+  {{- if eq .name "BASE_PATH" }}
+    {{- .value }}
+  {{- end }}
+{{- end }}
+{{- end }}
diff --git a/charts/memgraph-lab/templates/deployment.yaml b/charts/memgraph-lab/templates/deployment.yaml
@@ -39,11 +39,11 @@ spec:
               protocol: TCP
           livenessProbe:
             httpGet:
-              path: /check
+              path: {{ include "getBasePath" . }}/check
               port: http
           readinessProbe:
             httpGet:
-              path: /check
+              path: {{ include "getBasePath" . }}/check
               port: http
           resources:
             {{- toYaml .Values.resources | nindent 12 }}

diff --git a/charts/memgraph-lab/values.yaml b/charts/memgraph-lab/values.yaml
@@ -39,20 +39,20 @@ serviceAccount:
   # If not set and create is true, a name is generated using the fullname template
   name: ""
 
-
 imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""
 
 # Supported env variables: https://memgraph.com/docs/data-visualization/install-and-connect#environment-variables
 env:
-  - name: QUICK_CONNECT_MG_HOST
-    value: memgraph
-  - name: QUICK_CONNECT_MG_PORT
-    value: "7687"
+- name: QUICK_CONNECT_MG_HOST
+  value: memgraph-db
+- name: QUICK_CONNECT_MG_PORT
+  value: "7687"
+- name: BASE_PATH
+  value: ""
 
 podSecurityContext: {}
-  # fsGroup: 2000
 
 securityContext: {}
   # capabilities:
@@ -69,10 +69,10 @@ ingress:
     # kubernetes.io/ingress.class: nginx
     # kubernetes.io/tls-acme: "true"
   hosts:
-    - host: chart-example.local
-      paths:
-        - path: /
-          pathType: ImplementationSpecific
+  - host: chart-example.local
+    paths:
+    - path: /
+      pathType: ImplementationSpecific
   tls: []
   #  - secretName: chart-example-tls
   #    hosts: