Feature/220 space api #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proffalken
force-pushed
the
feature/220-SpaceAPI
branch
from
48a7a1e to
4fc2a7f
Compare
|
Heya @proffalken I've left a few comments with some suggested changes. Looks really good and would be great to merge after! Also it would be good to check a few sample outputs against the space api validator below before we merge just to make sure it hasn't broken anything. |
jabelone
requested changes
Oct 22, 2023
…ment for SpaceAPI
proffalken
force-pushed
the
feature/220-SpaceAPI
branch
from
09638a3 to
9e20c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220 (possibly! 🤣 )
This is an attempt to start the migration of certain parts of the SpaceAPI integration from Constance to a more dynamic way of working.
It allows for the space state (open/close) and message to be set via a database model, and also provides
sensorsthat can be added to the database inline with the JSON Schema for SpaceAPI.