Add ACTIVATE_VERSION message support #607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as stale. I did not have bandwidth at the time to get everything polished/tested. But future developers could definitely use this as a starting point. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/227
Originally created by @aaronsteers on 2021-12-16 23:12:14
Resolves #18, targets !44
From the issue:
When
FULL_TABLEreplication is selected in the tap:versionas property within emittedRECORDmessages. https://github.com/transferwise/pipelinewise-tap-snowflake/blob/aa89f2e4235999dbeafc7406a7f8b382542d8d5b/tap_snowflake/sync_strategies/common.py#L200[ ]EmitACTIVATE_VERSIONat the beginning of the firstFULL_TABLEsync operation: https://github.com/transferwise/pipelinewise-tap-snowflake/blob/aa89f2e4235999dbeafc7406a7f8b382542d8d5b/tap_snowflake/sync_strategies/full_table.py#L87-L95ACTIVATE_VERSIONafter a successfulFULL_TABLEsync: https://github.com/transferwise/pipelinewise-tap-snowflake/blob/aa89f2e4235999dbeafc7406a7f8b382542d8d5b/tap_snowflake/sync_strategies/full_table.py#L114Except for step
#3, this MR should resolve the requirements forACTIVATE_VERSION. I believe that point#3is an optional optimization and can safely be omitted from our initial implementation.