Port over external CSP3 hash support #137
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commits/hash-external-scripts Migrate tests to use Promises so we don't run into timeouts
Fix jest correctly asserting on webpack compilation warnings/errors Add missing meta tag to external-scripts-styles.html
melloware
requested changes
Oct 17, 2023
|
OK let me know when its ready and I will push 6.0.5 to NPM |
|
This is not actually working for non-online scripts. The webpack hooks when emitting JS files or other assets don't get called. I'm not sure I'll have the time to look into this because we'll probably move to using nonces instead of hashes. |
|
No worries lets leave this draft open for others to see in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed this so I tried to port over the original PR by @sersorrel from slackhq/csp-html-webpack-plugin#87. Apart from adding the support for hashing external scripts I also changed the way jest tests are run: if they fail, jest would go into timeout since done() was never called. Instead I moved it over to Promises, so fails are fast.
All tests are green with this but I haven't tried it out in practice.
This should fix #74