Added the icon and title to the site #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for github-spy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@parassareen4 : use a proper commit message. |
parassareen4
force-pushed
the
main
branch
2 times, most recently
from
b2000a3 to
13e4a75
Compare
- Corrected passport authentication flow for login route. - Fixed CORS setup to handle credentials in frontend requests. - Implemented session handling for login and signup at (/signup)and(/login). - Updated API endpoints to return appropriate error messages and status codes
|
signup is on /signup route and login on /login |
yashksaini-coder
requested changes
Dec 5, 2024
mehul-m-prajapati
requested changes
Dec 6, 2024
yashksaini-coder
approved these changes
Dec 6, 2024
parassareen4
commented
Dec 15, 2024
@parassareen4 good all changes look fine to me, @mehul-m-prajapati please look into this PR. I think it's good enough to be merged now. |
|
@mehul-m-prajapati Kindly merge this PR |
|
@yashksaini-coder : okay, I will test and merge today. |
the tests went fine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
🚀 Feature: Add login/signup page to connect with backend auth APIs of nodejs #19
Description
How Has This Been Tested?
Screenshots (if applicable)
Type of Change