Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created About, Contact page with responsive #33

Closed
wants to merge 4 commits into from

Conversation

saurabh142003
Copy link

@saurabh142003 saurabh142003 commented Nov 16, 2024

Related Issue


Description

I contributed by creating a responsive About, Contact Page using React, ensuring it adapts seamlessly to various screen sizes. Additionally, I implemented a menu bar specifically designed for mobile view, enhancing the navigation experience for users on smaller devices. To make the design more interactive and visually appealing, I incorporated React Icons throughout the page. This contribution improves the overall responsiveness and usability of the application.


How Has This Been Tested?


Screenshots (if applicable)

Screenshot 2024-11-16 234602
Screenshot 2024-11-16 234146
Screenshot 2024-11-16 233942
image
image
image


Type of Change

Added menu button in mobile view, improved responsiveness and Created About, Contact page with responsive

  • Bug fix
  • New feature
  • Code style update
  • Breaking change
  • Documentation update

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for github-spy ready!

Name Link
🔨 Latest commit a600d40
🔍 Latest deploy log https://app.netlify.com/sites/github-spy/deploys/673b7cbee73a3d00076773e4
😎 Deploy Preview https://deploy-preview-33--github-spy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mehul-m-prajapati
Copy link
Owner

@saurabh142003 : please fill description

@saurabh142003
Copy link
Author

@saurabh142003 : please fill description

Done

@mehul-m-prajapati
Copy link
Owner

@saurabh142003 : please reduce the size of font of navbar text => Dashboard, About, Contact

@saurabh142003
Copy link
Author

@saurabh142003 : please reduce the size of font of navbar text => Dashboard, About, Contact
Done

@mehul-m-prajapati
Copy link
Owner

@saurabh142003 : where is html code of about page?

@mehul-m-prajapati mehul-m-prajapati changed the title SaurabhM Before: Missing menu button in mobile view and contact page After: Added menu button in mobile view, improved responsiveness and Created Contact page with responsive Added menu button in mobile view, improved responsiveness and Created Contact page with responsive Nov 18, 2024
@saurabh142003
Copy link
Author

@saurabh142003 : where is html code of about page?

Done

@saurabh142003 saurabh142003 changed the title Added menu button in mobile view, improved responsiveness and Created Contact page with responsive Added menu button in mobile view, improved responsiveness and Created About, Contact page with responsive Nov 18, 2024
@mehul-m-prajapati
Copy link
Owner

@saurabh142003 : resolve conflicts and remove responsiveness changes.

Add only about, contact page changes

@saurabh142003
Copy link
Author

@saurabh142003 : resolve conflicts and remove responsiveness changes.

Add only about, contact page changes

  1. I have removed my responsiveness from the navbar
  2. Changed app.jsx file by changing the route path structure
  3. I have changed the anchor tag to link tag when it is mob- responsive because it was reloading the page in mobile responsive
    photo-collage png

Query : Do i have to change the folder structure by removing the about and contact page from component folder and add it to pages folder?

@mehul-m-prajapati mehul-m-prajapati changed the title Added menu button in mobile view, improved responsiveness and Created About, Contact page with responsive Created About, Contact page with responsive Nov 18, 2024
@mehul-m-prajapati
Copy link
Owner

@saurabh142003 : open a pull request with a branch. Dont commit your changes directly on main branch

You need to pull latest changes and then do yours

@saurabh142003
Copy link
Author

@saurabh142003 : open a pull request with a branch. Dont commit your changes directly on main branch

You need to pull latest changes and then do yours

Ok give me a sec

@saurabh142003
Copy link
Author

@saurabh142003 : open a pull request with a branch. Dont commit your changes directly on main branch

You need to pull latest changes and then do yours

what shall i do? the contact page and about page has already been made.
Screenshot 2024-11-18 234416
Screenshot 2024-11-18 234429

@mehul-m-prajapati
Copy link
Owner

@saurabh142003 - please work on some other issue

@saurabh142003
Copy link
Author

@saurabh142003 - please work on some other issue

No i'm not gonna do thank you for wasting my time!

@mehul-m-prajapati
Copy link
Owner

@saurabh142003 : dude, be respectful. Open source is about contributions.

If you do this again, I will report your account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile responsiveness
2 participants