Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend search #17

Closed
wants to merge 132 commits into from
Closed

Extend search #17

wants to merge 132 commits into from

Conversation

beque
Copy link

@beque beque commented Jan 16, 2023

Add search overlay for advanced search and ketcher rails
Search result shown in overlay

github-actions[bot]
github-actions bot reviewed Jan 16, 2023
View reviewed changes
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/models/report.rb Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jan 16, 2023
View reviewed changes
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jan 19, 2023
View reviewed changes
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jan 19, 2023
View reviewed changes
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
jhmegorei
jhmegorei requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@jhmegorei jhmegorei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin mal soweit ich gekommen bin drübergepflügt.

Bin gern bereit alles was ich angemerkt habe nochmal zu erläutern und meine Gedankengänge darzulegen :)

.gitignore Show resolved Hide resolved
README-DEV.md Show resolved Hide resolved
README-DEV.md Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/models/report.rb Show resolved Hide resolved
app/packs/src/components/searchModal/forms/KetcherRailsForm.js Outdated Show resolved Hide resolved
app/packs/src/components/searchModal/forms/KetcherRailsForm.js Outdated Show resolved Hide resolved
app/packs/src/components/searchModal/forms/KetcherRailsForm.js Outdated Show resolved Hide resolved
app/packs/src/components/searchModal/forms/KetcherRailsForm.js Outdated Show resolved Hide resolved
app/packs/src/components/searchModal/forms/SearchResult.js Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jan 24, 2023
View reviewed changes
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Show resolved Hide resolved
beque
beque commented Jan 24, 2023
View reviewed changes
Copy link
Author

@beque beque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erste Überarbeitung der Anregungen / Optimierungen

@github-actions
Copy link

LCOV of commit d6682a6 during Continuous Integration #34

Summary coverage rate:
  lines......: 58.5% (10983 of 18762 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions[bot]
github-actions bot reviewed Jan 26, 2023
View reviewed changes
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
@github-actions
Copy link

LCOV of commit 8e17185 during Continuous Integration #36

Summary coverage rate:
  lines......: 58.6% (10988 of 18761 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit aa28436 during Continuous Integration #37

Summary coverage rate:
  lines......: 58.6% (10989 of 18764 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

LCOV of commit 0b63b24 during Continuous Integration #38

Summary coverage rate:
  lines......: 58.6% (10988 of 18765 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

LCOV of commit 768dd97 during Continuous Integration #40

Summary coverage rate:
  lines......: 58.6% (11009 of 18776 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

LCOV of commit 384cce9 during Continuous Integration #41

Summary coverage rate:
  lines......: 58.6% (11007 of 18776 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions[bot]
github-actions bot reviewed Feb 8, 2023
View reviewed changes
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Feb 8, 2023
View reviewed changes
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/suggestion_api.rb Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

LCOV of commit c356267 during Continuous Integration #43

Summary coverage rate:
  lines......: 58.7% (11037 of 18807 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

LCOV of commit 2c89a56 during Continuous Integration #44

Summary coverage rate:
  lines......: 58.7% (11039 of 18807 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

LCOV of commit d1d7b8b during Continuous Integration #45

Summary coverage rate:
  lines......: 58.7% (11036 of 18807 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

LCOV of commit ac6694b during Continuous Integration #46

Summary coverage rate:
  lines......: 58.7% (11038 of 18807 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

LCOV of commit ef72030 during Continuous Integration #47

Summary coverage rate:
  lines......: 58.7% (11038 of 18807 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions[bot]
github-actions bot reviewed Feb 16, 2023
View reviewed changes
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
app/api/chemotion/search_api.rb Outdated Show resolved Hide resolved
@github-actions
Copy link

LCOV of commit 0699d48 during Continuous Integration #49

Summary coverage rate:
  lines......: 58.6% (11046 of 18838 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit c44fb1a during Continuous Integration #50

Summary coverage rate:
  lines......: 58.6% (11047 of 18838 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

beque added 25 commits December 20, 2023 12:23
@beque
Add usecase for structure search
850f7da
@beque
Remove old generic search, cleanup
7cdf795
@beque
Fix scopes for suggestion search
7c74344
@beque
Add unit tests for advanced, structure and by_ids search
38df35a
@beque
Fix rubocops
e4a11db
@beque
Fix wrong html structure at advanced search row
5869b6b
@beque
Add cypress test and identificator for search modal
f890fe1
@beque
Fix content to plain text at container for tests
719f056
@beque
Fix search usecases for new labimotion gem
6155add
@beque
Fix case insensitive, Add decoupled fields to sample
99d847e
@beque
Fix search queries
c0de2b4
@beque
Try to fix treeselect with showSearch
287b050
@beque
Fix select fields for sample advanced search
7800ef3
@beque
Fix some strange things
d328881
@beque
Fix some research plan, style bugs
e53a094
@beque
Fix error when search conditions are empty
66d1c28
@beque
Fix solvent search and screen search
5cfdfaf
@beque
Add better error messages, some fixes
8a5f5e6
@beque
Change width and height of search modal, advanced search value, multi…
75f4414 
…line search value
@beque
Fix prefilled name field for advanced search
c99295b
@beque
Add publication search
82f1159
@beque
Fix some errors and styles
f1ae47b
@beque
Fix click on pagination at reactions search result
1ebd88d
@beque
Fix sorting on remove search result, search modal height
f68b77b
@beque
Fix rubocop errors
46631a7
@github-actions GitHub Actions
Copy link

LCOV of commit 46631a7 during Continuous Integration #167

Summary coverage rate:
  lines......: 63.0% (12745 of 20245 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@beque beque closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jhmegorei jhmegorei jhmegorei requested changes

@matt-hh matt-hh matt-hh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beque @matt-hh @jhmegorei