-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototypical CHT values: use 2024 cert, not 2023, use Core v4.6, not v4.2 #11
Conversation
@nydr - looking at what we tell people to use for EKS as a sane default, seems like we could also make these changes as sane defaults that you almost always want unless you really know what you're doing. Deferring to you though b/c I'm just kinda guessing!
|
Looks good
IMO this should be autogenerated see cht-user secret.yml, additionally I think it should be unique for each node, and currently it looks like it sets each node in a cluster to the same which seems unintentional. Not sure about the implications of sharing uuid across a couchdb cluster. FYI @Hareet @henokgetachew @dianabarsan
It is tied to medic AWS account so I would not expect it to change
This isn't being used in the helm chart but for the cht-deploy for creating route53 dns entries, I think this logic should be removed since .dev has wildcard dns to eks dev so it is not needed and most users don't have dns edit access. Thoughts @Hareet @henokgetachew ?
This field is being made optional and default disabled in #5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version in Chart.yaml should be updated, otherwise LGTM!
I'd expect this PR to be @nydr - what do you recommend? |
noting from slack thread @garethbowen suggests:
Yes, we are using in prod ;) fixed in aba4bd8 |
No description provided.