-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(#29): Add data audit brac models #37
Conversation
@njuguna-n I implemented audits for both |
@lorerod & @njuguna-n, can you please support with answering the following questions:
|
I started implementing auditing macros using the 'audit_helper' package. This package's primary purpose is to help with the table auditing process and ensure that a refactored model provides the same output as the original one. Although it is not useful for the comparison we are doing now between couch2pg queries and cht-pipeline models, it will be helpful when we refactor existing models. However, as priorities changed, I decided to help Njuguna by providing a manual comparison of the widgets and data sources.
I only implemented three models, so much remains to be done. To keep things organized, I'm going to separate this PR from the Data audit for BRAC models issue and initiate a new issue for audit for refactoring purposes. We can prioritize it for later. |
Also, I will make that issue related to the default models, not the BRAC models. |
Issue created. I will use this draft PR as an example of how to implement auditing on models at #80 |
@lorerod given the pipeline model changes, is this PR still relevant? |
This PR is not relevant anymore. Thanks, @andrablaj, for the cleanup. |
Add data audit to BRAC dbt models