Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add users meta base models #181

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Conversation

njuguna-n
Copy link
Contributor

Description

Add telemetry and feedback base models

closes #180

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@njuguna-n njuguna-n changed the title 180 users meta base models feat: add users meta base models Nov 14, 2024
@njuguna-n njuguna-n requested a review from witash November 15, 2024 10:42
@njuguna-n njuguna-n marked this pull request as ready for review November 15, 2024 10:42
@njuguna-n
Copy link
Contributor Author

@witash please review these models meant to help with the eCHIS telemetry work.

Copy link
Contributor

@witash witash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdndiaye
Copy link

Hi @njuguna-n Are you planning to add any more telemetry to this model? Based on this list, there's still more to add. cc @1yuv

@njuguna-n
Copy link
Contributor Author

Hello @jdndiaye, this PR is meant to provide base models similar to the ones from the main database and not extract all available telemetry data. Are there metrics common across deployments that we should here?

@jdndiaye
Copy link

jdndiaye commented Nov 20, 2024

Are there metrics common across deployments that we should here?

I know that some of them depend on the version deployed. But we can just limit ourselves to the indicators listed here.

models/users/telemetry.sql Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@njuguna-n njuguna-n merged commit c5b8285 into main Dec 6, 2024
5 checks passed
@njuguna-n njuguna-n deleted the 180-users-meta-base-models branch December 6, 2024 13:04
medic-ci pushed a commit that referenced this pull request Dec 6, 2024
# [1.4.0](v1.3.1...v1.4.0) (2024-12-06)

### Features

* add users meta base models ([#181](#181)) ([c5b8285](c5b8285))
@medic-ci
Copy link

medic-ci commented Dec 6, 2024

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add users meta base models
5 participants