Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty strings, bull values, and incorrect dates for date_… #163

Closed
wants to merge 1 commit into from

Conversation

njuguna-n
Copy link
Contributor

…of_birth column

Description

Handle non-date values in the date_of_birth column

closes #162

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@njuguna-n njuguna-n requested a review from witash September 12, 2024 07:04
@njuguna-n
Copy link
Contributor Author

@witash I see we already have NULLIF on this column. I'll update the version of cht-pipeline used by the MoH deployment instead.

@njuguna-n njuguna-n closed this Sep 12, 2024
@njuguna-n njuguna-n deleted the 162-handle-incorecct-dates-person-model branch September 12, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle empty dates in the person model
2 participants