Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

136 - Dialog with "prominent" disclosure to request location #142

Merged
merged 25 commits into from
Jan 12, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
793af9f
"prominent" disclosure dialog to request user location permissions
mrsarm Dec 17, 2020
447562c
Add 'x86' platform to the build. Fix javadoc
mrsarm Dec 17, 2020
3e13379
Fix error when form is submitted and no location perm allowed
mrsarm Dec 17, 2020
6234057
Commented the code that enables 'x86' builds
mrsarm Dec 17, 2020
4a1bb11
Fix android checkstyle error
mrsarm Dec 18, 2020
62b8e29
Localization of the location dialog (default only)
mrsarm Dec 18, 2020
e7044a1
Location disclosure refactor: change dialog by an activity / layout
mrsarm Dec 22, 2020
b3b7531
Update location disclosure title
mrsarm Dec 22, 2020
b08c7da
Fix bug when handling location permission
mrsarm Dec 22, 2020
f70398a
Disclosure of location view: reduce a bit margin top
mrsarm Dec 22, 2020
9783fe1
Remove redundant exception catch and remove trace of useless log
mrsarm Dec 22, 2020
25e923e
Disclosure of location view: camelCase for string names
mrsarm Dec 22, 2020
656106d
Fix random assignment of request codes
mrsarm Dec 22, 2020
5528555
Use GH variables for setting the version number
garethbowen Dec 22, 2020
46adb7b
Add main languages for disclosure location view. Reduce padding to be…
mrsarm Dec 28, 2020
a6f9974
Better logging of request codes
mrsarm Dec 28, 2020
d835365
Disable translation lints because are optional
mrsarm Dec 28, 2020
30e09b0
French translation fix
mrsarm Dec 29, 2020
899b4e2
Update main location disclosure message and translations
mrsarm Dec 30, 2020
72b5292
Remove unused translations strings
mrsarm Jan 5, 2021
df664ee
Add release notes
mrsarm Jan 5, 2021
9195e5a
Update README.md
mrsarm Jan 6, 2021
cfc452f
Update README.md about translations
mrsarm Jan 6, 2021
72999fc
Add Bamanankan (Bambara) translations
mrsarm Jan 7, 2021
68e7f91
Avoid result code collisions (#146)
craig-landry Jan 11, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@ The medic-android application is a thin wrapper to load the [CHT Core Framework]

# Release notes

## 0.7.0

### Changes

- [feature] [medic-android#136](https://github.com/medic/medic-android/issues/136): Add UI for prominent disclosure when requesting for permissions.
mrsarm marked this conversation as resolved.
Show resolved Hide resolved

### Notes

The new view that requests location permissions has in the source code text translated to the main languages we support. These translation don't follow the rules from the [How To Manage Translations](https://docs.communityhealthtoolkit.org/core/overview/translations/) because Android has its own [localization framework](https://developer.android.com/guide/topics/resources/localization) and there are just a handful of phrases translated.
mrsarm marked this conversation as resolved.
Show resolved Hide resolved


## 0.6.0

### Upgrade notes
Expand Down
1 change: 0 additions & 1 deletion src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
<string name="locRequestOkButton">Activar</string>
<string name="locRequestDenyButton">No gracias</string>
<string name="locRequestIconDescription">Ícono de mi ubicación</string>
<string name="locRequestMapIconDescription">Ícono de ubicación en el mapa</string>
</resources>
1 change: 0 additions & 1 deletion src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
<string name="locRequestOkButton">Activer</string>
<string name="locRequestDenyButton">Non merci</string>
<string name="locRequestIconDescription">Icône de mon emplacement</string>
<string name="locRequestMapIconDescription">Emplacement dans l\'icône de la carte</string>
</resources>
1 change: 0 additions & 1 deletion src/main/res/values-hi/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
<string name="locRequestOkButton">चालू करो</string>
<string name="locRequestDenyButton">जी नहीं, धन्यवाद</string>
<string name="locRequestIconDescription">मेरा स्थान आइकन</string>
<string name="locRequestMapIconDescription">मानचित्र आइकन में स्थान</string>
</resources>
1 change: 0 additions & 1 deletion src/main/res/values-in/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
<string name="locRequestOkButton">Nyalakan</string>
<string name="locRequestDenyButton">Tidak, terima kasih</string>
<string name="locRequestIconDescription">Ikon lokasiku</string>
<string name="locRequestMapIconDescription">Lokasi di ikon peta</string>
</resources>
1 change: 0 additions & 1 deletion src/main/res/values-ne/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
<string name="locRequestOkButton">खोल्नुहोस्</string>
<string name="locRequestDenyButton">धन्यबाद</string>
<string name="locRequestIconDescription">मेरो स्थान आइकन</string>
<string name="locRequestMapIconDescription">नक्शा आइकनमा स्थान</string>
</resources>
1 change: 0 additions & 1 deletion src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,4 @@
<string name="locRequestOkButton">Turn on</string>
<string name="locRequestDenyButton">No thanks</string>
<string name="locRequestIconDescription">My location icon</string>
<string name="locRequestMapIconDescription">Location in map icon</string>
</resources>