-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#20): fix incorrect days in 2081 #23
Conversation
Hi @garethbowen, can you help with this PR? I tried to solve the failing test on #25 but still have some issues. I will need your help there, too. |
@aloundoye All the builds are too old so I cannot see why they failed any more. Can you push a change to this branch to kick off the build again and let me know when it fails? |
@garethbowen, for |
Ahh, if you look at the "annotations" for those builds it's because the environment is deprecated:
So there more updates required to even get the action to start running. |
Ah, thanks @garethbowen . I missed that it works now all the tests passed #25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking with this! I think just make the one change recommended and it'll be clean and good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one
fix #20