Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#20): fix incorrect days in 2081 #23

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

aloundoye
Copy link

fix #20

@aloundoye
Copy link
Author

Hi @garethbowen, can you help with this PR? I tried to solve the failing test on #25 but still have some issues. I will need your help there, too.

@garethbowen
Copy link

@aloundoye All the builds are too old so I cannot see why they failed any more. Can you push a change to this branch to kick off the build again and let me know when it fails?

@aloundoye
Copy link
Author

@garethbowen, for test java I fixed it here, #25, but the other tests are not even running it is marked This job failed

@garethbowen
Copy link

Ahh, if you look at the "annotations" for those builds it's because the environment is deprecated:

The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

So there more updates required to even get the action to start running.

@aloundoye
Copy link
Author

Ah, thanks @garethbowen . I missed that it works now all the tests passed #25

@aloundoye aloundoye marked this pull request as draft November 4, 2024 15:12
@aloundoye aloundoye marked this pull request as ready for review November 5, 2024 02:34
@aloundoye aloundoye requested a review from garethbowen November 5, 2024 02:34
Copy link

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with this! I think just make the one change recommended and it'll be clean and good to go.

java/lib/src/main/java/bikramsambat/BsCalendar.java Outdated Show resolved Hide resolved
@aloundoye aloundoye requested a review from garethbowen November 5, 2024 12:52
Copy link

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@aloundoye aloundoye merged commit a423b40 into medic:master Nov 5, 2024
8 checks passed
@aloundoye aloundoye deleted the 20-incorrect-day-in-2081 branch November 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect daysInMonth data for year 2081
2 participants