Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hybrids off #84

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Feature/hybrids off #84

merged 7 commits into from
Nov 21, 2023

Conversation

CatarinaCarolina
Copy link
Collaborator

implemented --hybrids-off flag, when toggled BGCs with hybrid classes/categories get put in the bins of all classes, and no hybrid class bins are made
so -> terpene.NRPS BGC gets put in the terpene and NRPS bin. (if not toggled, would be put in terpene.NRPS bin)

also minor bug fixing in product parsing and allowing cutoffs with more than 1 decimal

Copy link
Collaborator

@adraismawur adraismawur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor thing, looks good otherwise

big_scape/comparison/binning.py Outdated Show resolved Hide resolved
@CatarinaCarolina CatarinaCarolina merged commit 6ce0018 into dev Nov 21, 2023
7 checks passed
@CatarinaCarolina CatarinaCarolina deleted the feature/hybrids-off branch November 28, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants