New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix result generation crash on multiple cutoffs #150

Closed

adraismawur wants to merge 1 commit into dev from hotfix/multi-cutoff-output

Collaborator

adraismawur commented Apr 19, 2024 •

edited

Loading

The changes in the PR fix the crash during output generation when using multiple cutoff values by doing the following:

Change generate_bs_families_members to be more robust
Change much of the family alignment code to work with the full list of records instead of reducing it to a partial family list, which was confusing (generate_bs_family_alignment)

A final problem remains where the GCF trees are generated (sort of) correctly, but:

Some trees (with only one or two members?) do not correctly generate, instead looking like this:

>2

(That's it. That's the file)

tree .fasta and .newick file names are mismatched with the families in the results. I don't know how


          fix result generation crash on multiple cutoffs

66f8820

adraismawur closed this

adraismawur deleted the hotfix/multi-cutoff-output branch

May 8, 2024 12:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet