Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MessageWriter to MessagePacker. #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mark-Simulacrum
Copy link
Contributor

Writers send data to the network (and the file MessagePacker does not do this).

Writers send data to the network (and the file MessagePacker does not do this).
@rousskov
Copy link
Contributor

rousskov commented Apr 7, 2016

I suggest also renaming rawFoo() function in MessagePacker to packFoo() functions. This will complete the symmetry with parseFoo() methods in MessageParser.

Despite this renaming, I would leave the Header::_raw data member as is for now. It could be renamed to packed later, but I expect us to add some protocol version information to that data member so that HTTP/2 packers do not accidentally return pre-packed HTTP/1 headers. Until then, the raw/packed name disparity may alert developers of the potential raw usage problems.

@Mark-Simulacrum
Copy link
Contributor Author

Fixed merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants