feat: add syncHostStyles API to disable iframe style sync #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvxd
force-pushed
the
make-types-more-robust
branch
2 times, most recently
from
559f781
to
e4cca94
Compare
chrisvxd
force-pushed
the
add-disable-sync-api
branch
from
8d701fc
to
884328a
Compare
chrisvxd
force-pushed
the
add-disable-sync-api
branch
from
884328a
to
2cce878
Compare
chrisvxd
force-pushed
the
add-disable-sync-api
branch
from
2cce878
to
112e9bc
Compare
chrisvxd
commented
Sep 13, 2024
| Sync the host styles to the iframe. Defaults to `true`. | ||
|
|
||
| If this isn't working, you may need to inject styles manually using the iframe [override API](/docs/api-reference/overrides/iframe), or make use of a [plugin](/docs/extending-puck/plugins). | ||
|
|
There was a problem hiding this comment.
This API won't work until we can isolate the Puck styles from the required styles. Setting syncHostStyles to false will prevent any Preview styles from loading, making the preview unusable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on for #409
CC @nicolas-angelo