added GB banks to the registry #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdomke
requested changes
Jul 4, 2024
| "short_name": "ABN AMRO BANK ", | ||
| "primary": true | ||
| "primary": true, | ||
| "bic": "HALIFAX (A TRADING NAME OF BANK OF SCOTLAND PLC)", |
| "primary": true | ||
| "primary": true, | ||
| "bic": "REVO", | ||
| "bank_code": "REVOGB21", |
There was a problem hiding this comment.
I think bank_code and bic are mixed up here.
There was a problem hiding this comment.
REVOGB21 looks like a good bic to me:
There was a problem hiding this comment.
Yes. But the bank identifier has to be 4 letters
|
@Ahmad-cercli Can you please execute the tests. They will directly tell you which new entries are incorrect. |
Natim
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new banks in banks registry from issue #138
Banks that were added:
MONZGB2L
PAYRGB2L
DZNNGB22
CPBKGB22
YORKGB22
TCCLGB3L
TSBSGB2A
I've noticed that some banks from the existing registry are now inactive.. so I will note those:
Inactive swift codes:
PRTCGB21
HLFXGB21N85
TCCLGB31XXX
PAYRGB21
PAEDGB21XXX
REVOGB21XXX
CLJUGB21XXX
PRTCGB21XXX
REVOGB21
CPBKGB21CAR
Deleted from network:
SVBKGB2L
I haven't removed them from the registry, but I am noting this for future reference.
Thank you :)