Fix bad git-min alias resolves tag permanently #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the `gtg-min` alias, using double-quotes calls git-semver immediately and encodes the current tag permanently in the alias. Then, every time you call the alias, it uses the same tag and fails with `fatal: tag 'x.y.z' already exists`. We change it to single quotes so that the subcommand is not resolved at definition and calling the alias will generate a new tag every time. Fixes mdomke#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
gtg-minalias, using double-quotes calls git-semver immediately and encodes the current tag permanently in the alias. Then, every time you call the alias, it uses the same tag and fails withfatal: tag 'x.y.z' already exists.We change it to single quotes so that the subcommand is not resolved at definition and calling the alias will generate a new tag every time.
Fixes #43