Merge pull request #228 from JonKing93/master

Type checking of nodata values
mdbartos · Dec 4, 2023 · 174cafa · 174cafa
2 parents 7f70cca + eb41cae
commit 174cafa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pysheds/sview.py b/pysheds/sview.py
@@ -82,7 +82,7 @@ def __new__(cls, input_array, viewfinder=None, metadata={}):
         except:
             raise TypeError('`object` and `flexible` dtypes not allowed.')
         try:
-            assert np.min_scalar_type(viewfinder.nodata) <= obj.dtype
+            assert np.can_cast(viewfinder.nodata, obj.dtype, casting='safe')
         except:
             raise TypeError('`nodata` value not representable in dtype of array.')
         # Don't allow original viewfinder and metadata to be modified
@@ -288,7 +288,7 @@ def __new__(cls, input_array, viewfinder=None, metadata={}):
         except:
             raise TypeError('`object` and `flexible` dtypes not allowed.')
         try:
-            assert np.min_scalar_type(viewfinder.nodata) <= obj.dtype
+            assert np.can_cast(viewfinder.nodata, obj.dtype, casting='safe')
         except:
             raise TypeError('`nodata` value not representable in dtype of array.')
         # Don't allow original viewfinder and metadata to be modified