fixed missing default null for Reason

md-redwan-hossain · Oct 4, 2024 · ee02942 · ee02942
1 parent c5c3182
commit ee02942
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/SharpOutcome/Helpers/HttpBadOutcome.cs b/src/SharpOutcome/Helpers/HttpBadOutcome.cs
@@ -8,7 +8,8 @@ namespace SharpOutcome.Helpers;
 /// </summary>
 /// <param name="Tag">The unique tag of the bad outcome.</param>
 /// <param name="Reason">The reason for the bad outcome (optional).</param>
-public readonly record struct HttpBadOutcome(HttpBadOutcomeTag Tag, string? Reason) : IBadOutcome<HttpBadOutcomeTag>;
+public readonly record struct HttpBadOutcome(HttpBadOutcomeTag Tag, string? Reason = null)
+    : IBadOutcome<HttpBadOutcomeTag>;
 
 /// <summary>
 /// Represents an HTTP bad outcome with a payload of type <typeparamref name="TPayload"/>.
@@ -17,5 +18,5 @@ namespace SharpOutcome.Helpers;
 /// <typeparam name="TPayload">The type of the payload.</typeparam>
 /// <param name="Payload">The payload that carries contextual data.</param>
 /// <param name="Reason">The reason for the bad outcome (optional).</param>
-public readonly record struct HttpBadOutcome<TPayload>(HttpBadOutcomeTag Tag, TPayload Payload, string? Reason)
+public readonly record struct HttpBadOutcome<TPayload>(HttpBadOutcomeTag Tag, TPayload Payload, string? Reason = null)
     : IBadOutcomeWithPayload<HttpBadOutcomeTag, TPayload>;
diff --git a/src/SharpOutcome/Helpers/HttpGoodOutcome.cs b/src/SharpOutcome/Helpers/HttpGoodOutcome.cs
@@ -8,7 +8,7 @@ namespace SharpOutcome.Helpers;
 /// </summary>
 /// <param name="Tag">The unique tag of the good outcome.</param>
 /// <param name="Reason">The reason for the good outcome (optional).</param>
-public readonly record struct HttpGoodOutcome(HttpGoodOutcomeTag Tag, string? Reason)
+public readonly record struct HttpGoodOutcome(HttpGoodOutcomeTag Tag, string? Reason = null)
     : IGoodOutcome<HttpGoodOutcomeTag>;
 
 /// <summary>
@@ -18,5 +18,5 @@ public readonly record struct HttpGoodOutcome(HttpGoodOutcomeTag Tag, string? Re
 /// <typeparam name="TPayload">The type of the payload.</typeparam>
 /// <param name="Payload">The payload that carries contextual data.</param>
 /// <param name="Reason">The reason for the good outcome (optional).</param>
-public readonly record struct HttpGoodOutcome<TPayload>(HttpGoodOutcomeTag Tag, TPayload Payload, string? Reason)
+public readonly record struct HttpGoodOutcome<TPayload>(HttpGoodOutcomeTag Tag, TPayload Payload, string? Reason = null)
     : IGoodOutcomeWithPayload<HttpGoodOutcomeTag, TPayload>;
diff --git a/src/SharpOutcome/SharpOutcome.csproj b/src/SharpOutcome/SharpOutcome.csproj
@@ -4,7 +4,7 @@
         <TargetFramework>net6.0</TargetFramework>
         <Nullable>enable</Nullable>
         <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
-        <Version>1.0.0</Version>
+        <Version>1.1.0</Version>
         <Title>SharpOutcome</Title>
         <Authors>Md. Redwan Hossain</Authors>
         <Copyright>Copyright (c) Md. Redwan Hossain</Copyright>