boot: zephyr: boot_record: Save boot data with single image #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Some fields should be excluded from single application mode, can you update boot/bootutil/src/boot_record.c and add ifdefs like so:
#if !defined(MCUBOOT_SINGLE_APPLICATION_SLOT)
if (!rc) {
rc = boot_add_data_to_shared_area(TLV_MAJOR_BLINFO,
BLINFO_RUNNING_SLOT,
sizeof(slot), (void *)&slot);
}
#endif
...
#if !defined(MCUBOOT_SINGLE_APPLICATION_SLOT)
while (image < BOOT_IMAGE_NUMBER && !rc) {
if (max_app_sizes[image].calculated == true) {
rc = boot_add_data_to_shared_area(TLV_MAJOR_BLINFO,
(BLINFO_MAX_APPLICATION_SIZE + image),
sizeof(max_app_sizes[image].max_size),
(void *)&max_app_sizes[image].max_size);
}
++image;
}
#endif
dpw13
force-pushed
the
dwagner/single-loader-blinfo
branch
from
e9629b2 to
f1a184b
Compare
dpw13
force-pushed
the
dwagner/single-loader-blinfo
branch
from
f1a184b to
1528e48
Compare
Ensure that bootloader info and measurements are saved to retained memory when using mcuboot in single-image mode. Signed-off-by: Dane Wagner <[email protected]>
dpw13
force-pushed
the
dwagner/single-loader-blinfo
branch
from
1528e48 to
d5cca5a
Compare
nordicjm
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that bootloader info and measurements are saved to retained memory when using mcuboot in single-image mode.