Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootutil/crypto: Fix x25519 not compiling with mbedTLS #1968

Closed
wants to merge 1 commit into from

Conversation

de-nordic
Copy link
Collaborator

Found on Zephyr wwhile trying to compile EDCSA25519 support with -DCONFIG_BOOT_ED25519_MBEDTLS=y, where compilation eneded up in errors.

It also seems that configuration has been dead for longer since the CMakeLists.txt has been needed to disable TinyCrypt source when mbedTLS is selected for ED25519.

This is addition to #1937, which addresses p256

Found on Zephyr wwhile trying to compile EDCSA25519 support
with -DCONFIG_BOOT_ED25519_MBEDTLS=y, where compilation eneded
up in errors.

It also seems that configuration has been dead for longer
since the CMakeLists.txt has been needed to disable TinyCrypt
source when mbedTLS is selected for ED25519.

Signed-off-by: Dominik Ermel <[email protected]>
@de-nordic
Copy link
Collaborator Author

de-nordic commented May 28, 2024

It seems to break Espressif that uses the internal module, different fix is needed for that.
The #1937 should be facing the same problem, but the CI does not run there.

Heh.. this PR breaks TinyCrypt... seems that CONFIG_BOOT_ED25519_TINYCRYPT=y requires mbedTLS for asn1...

@nvlsianpu nvlsianpu added the area: core Affects core functionality label Jun 11, 2024
@nvlsianpu nvlsianpu self-assigned this Jun 11, 2024
@utzig
Copy link
Member

utzig commented Jun 20, 2024

The CMake changes looks fine, I don't understand why you would need to remove the usages of MBEDTLS_CONTEXT_MEMBER.

@de-nordic
Copy link
Collaborator Author

The ASN stuff got fixed here: #1989

@nvlsianpu nvlsianpu added the crypto Encryption support label Jul 26, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, fixed by #1989

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, fixed by #1989

@de-nordic de-nordic closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Affects core functionality crypto Encryption support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants