boot: zephyr: serial_adapter: Fail if USB CDC enabled with console and fail to build if main thread is not preemptible #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
approved these changes
Nov 6, 2023
This prevents MCUboot from successfully building if console and serial recovery (USB CDC) are both enabled and they both point to the same device Signed-off-by: Jamie McCrae <[email protected]>
carlescufi
approved these changes
Nov 6, 2023
Adds a build failure if the main thread priority is not preemptible and USB CDC ACM serial recovery is used, this is because if this is the case, USB events will never be able to be processed and serial recovery cannot ever enumerate Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
changed the title
de-nordic
approved these changes
Nov 6, 2023
Fixes USB configurations so that they build out of the box, this previously falsely built successfully but would not run Signed-off-by: Jamie McCrae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents MCUboot from successfully building if console and serial recovery (USB CDC) are both enabled and they both point to the same device. Also adds a build failure if the main thread priority is not preemptible and USB CDC ACM serial recovery is used, this is because if this is the case, USB events will never be able to be processed and serial recovery cannot ever enumerate