bootutil: Disable MCUBOOT_BOOT_MAX_ALIGN assert for non-swap modes #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
butok
commented
Oct 4, 2023
butok
commented
- Assert should be checked only for SWAP update modes.
- Allow platforms with page size >32 Bytes (e.g. LPC) to use MCUBoot, at least for non-SWAP update modes.
nordicjm
requested changes
Oct 4, 2023
butok
force-pushed
the
disable_assert_non_swap
branch
from
83eedc9 to
fdc6159
Compare
You are right, Zephyr-specific. |
nordicjm
requested changes
Oct 4, 2023
- Assert should be checked only for SWAP update modes. - Allow platforms with page size >32 Bytes (e.g. LPC) to use MCUBoot, at least for non-SWAP update modes. Signed-off-by: Andrej Butok <[email protected]>
butok
force-pushed
the
disable_assert_non_swap
branch
from
fdc6159 to
9016b73
Compare
nordicjm
approved these changes
Oct 4, 2023
de-nordic
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.