Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill fhir auth #55

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Fill fhir auth #55

merged 5 commits into from
Nov 29, 2023

Conversation

KeeyanGhoreshi
Copy link
Contributor

@KeeyanGhoreshi KeeyanGhoreshi commented Nov 8, 2023

Describe your changes

Use with cds-hooks branch fhirAuth to get the fhirAuthorization populated in the hook. Make sure to set the environment variable to true as the default behavior is false, which will not add the fhirAuthorization.

FhirAuthorization information is pulled from the fhirclient.

Note that prettier will be complaining because cds-hooks submodule is not updated and it is based off dev branch still. It will go away once the cds-hooks branch is merged.

Issue ticket number and Jira link

REMS-364

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@KeeyanGhoreshi KeeyanGhoreshi changed the base branch from main to dev November 8, 2023 21:06
Copy link
Contributor

@jtquach1 jtquach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the order-select hook appears to send properly via the MedicationRequest dropdown.

  • With REACT_APP_SEND_FHIR_AUTH_ENABLED = false in my .env.local:
    I can see that for all 3 drugs, the fhirAuthorization field is not present.
  • With REACT_APP_SEND_FHIR_AUTH_ENABLED = true in my .env.local:
    I can see that for all 3 drugs, the fhirAuthorization field is present.

Besides that, just requested minor changes.

README.md Outdated Show resolved Hide resolved
src/views/Patient/MedReqDropDown/MedReqDropDown.tsx Outdated Show resolved Hide resolved
@jtquach1
Copy link
Contributor

jtquach1 commented Nov 29, 2023

Also made a PR to update the corresponding Markdown file in mcode/rems-setup with REACT_APP_SEND_FHIR_AUTH_ENABLED and other new env vars.

mcode/rems-setup#18

@jtquach1 jtquach1 merged commit b4dd06d into dev Nov 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants