-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill fhir auth #55
Fill fhir auth #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, the order-select hook appears to send properly via the MedicationRequest dropdown.
- With
REACT_APP_SEND_FHIR_AUTH_ENABLED = false
in my.env.local
:
I can see that for all 3 drugs, thefhirAuthorization
field is not present. - With
REACT_APP_SEND_FHIR_AUTH_ENABLED = true
in my.env.local
:
I can see that for all 3 drugs, thefhirAuthorization
field is present.
Besides that, just requested minor changes.
Also made a PR to update the corresponding Markdown file in |
Co-authored-by: Joyce Quach <[email protected]>
Co-authored-by: Joyce Quach <[email protected]>
Describe your changes
Use with cds-hooks branch fhirAuth to get the fhirAuthorization populated in the hook. Make sure to set the environment variable to
true
as the default behavior isfalse
, which will not add the fhirAuthorization.FhirAuthorization information is pulled from the fhirclient.
Note that prettier will be complaining because cds-hooks submodule is not updated and it is based off dev branch still. It will go away once the cds-hooks branch is merged.
Issue ticket number and Jira link
REMS-364
Checklist before requesting a review
dev
not main (the only exception to this is releases fromdev
and hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.