Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange SMART on FHIR App UI #43

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Rearrange SMART on FHIR App UI #43

merged 4 commits into from
Sep 6, 2023

Conversation

jtquach1
Copy link
Contributor

@jtquach1
Copy link
Contributor Author

jtquach1 commented Sep 1, 2023

Screenshots (before) on iPad Mini simulated device:

1024x768

image
image
image

768x1024

image
image
image

Screenshots (after) on iPad Mini simulated device:

Two horizontal panes, 1024x768

image

image

image

Two vertical panes, 768x1024

image

image

image

@jtquach1 jtquach1 marked this pull request as ready for review September 1, 2023 22:09
@jtquach1 jtquach1 changed the title WIP: Rearrange UI Rearrange SMART on FHIR App UI Sep 1, 2023
Copy link
Contributor

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the code and the UI, everything looks good to me! I like the new style design.

@plarocque4
Copy link
Contributor

When the page is wide, should the patient information be 50% like we have now? Or should it be smaller with maybe a fixed maximum size since it's not the focus of the interface, it's really there for information purposes. The text "Launched with patient context:" should perhaps be smaller and just over the "Patient Info" section? We should discuss this at standup.
Overall it looks and works great though!

@jtquach1
Copy link
Contributor Author

jtquach1 commented Sep 5, 2023

Current (after) screenshots

image
image

image
image

Changes made

  • Reduced the ratio from 50:50 to 25:75 for the patient info and medication request panes
  • Added spacing between CDS Hooks Card buttons
  • Moved Grid component out of the medication request dropdown component

@plarocque4 plarocque4 merged commit c190605 into dev Sep 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants