Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in ability to take in take in SearchSet entries. #44

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

ChristineDuong
Copy link
Contributor

Submitter:

  • Make sure test coverage didn’t decrease. If you are allowing the test coverage to drop, leave an explanation as to why:
  • Does an update need to be made to the documentation with these changes?
  • Make sure there is an update to service library reference in the service wrappers/template once this PR is merged.
  • Does an update need to be made to the engine?
  • Was the new feature tested by unit tests?
  • Was the new feature tested by a manual, end-to-end test?

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (321ecc6) 96.99% compared to head (f7349a6) 97.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   96.99%   97.01%   +0.01%     
==========================================
  Files          14       14              
  Lines         932      938       +6     
  Branches      284      285       +1     
==========================================
+ Hits          904      910       +6     
  Misses          2        2              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zlister zlister merged commit 2872f1e into master Feb 6, 2024
4 checks passed
@zlister zlister deleted the searchset-update branch February 6, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants