Fix Bug: Hitting cancel on cmpdreg file upload widget new line causes "error..."

[hhan-schrodinger]

Description

Original Bug:

To reproduce:

• Click View/Edit files
• Upload a new file to the list
• The UI automatically adds another file chooser below the new file uploaded.
• Click the "cancel" button on this new file chooser line
• Click the "Upload" button

Expectation:

• The file I chose to upload is uploaded

Actual results:

• "error..." is displayed and the file is not uploaded.

Fix

Narrowed down the issue to this line in FileSaveSendDTO.java:
String writeup = writeupList.get(i);

If the user inserted text (even a blank space) in writeup even if they hit "cancel" on the new file chooser line, there would be no issue BUT if they left the writeup field in the form blank and hit cancel, the writeupList would be blank and the code would fail on this line.

I'm guessing maybe there is some weird logic happening on the frontend when the user hits cancel? Since when the user inserts any text into the field it is fine, I'm not as worried about altering the logic there and just added this line to handle weird cases where writeupList is empty and doesn't match the length of files.

How Has This Been Tested?

Reproduced the steps before and after the fix, and saw that the failure no longer occurred.

[brianbolt]

If you add a writeup to the first row would this fix still work?

Click View/Edit files
Upload a new file to the list
*Fill in the writeup to that row
The UI automatically adds another file chooser below the new file uploaded.
Click the "cancel" button on this new file chooser line
Click the "Upload" button

[hhan-schrodinger]

@brianbolt - yep, tried it and it works!

[brianbolt]

Great. LGTM