Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove roo as a dependency #312

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Apr 29, 2022

Description

This should be reviewed after #311

  • Remove roo from pom.xml
  • Removed all roo annotations
  • Pushed in all aspectj code

Related Issue

Fixes #307

How Has This Been Tested?

Ran acasclient tests
Verified login worked
Verified various code table browsers and editors worked
Verified experiment editor worked
Verified label sequence editor work

@brianbolt brianbolt changed the title Brianbolt/issue307 Remove roo as a dependency Apr 29, 2022
@brianbolt brianbolt requested a review from bffrost April 29, 2022 14:24
@bffrost bffrost changed the base branch from brianbolt/issue300 to release/1.13.7 April 29, 2022 15:45
@bffrost bffrost changed the base branch from release/1.13.7 to brianbolt/issue300 April 29, 2022 15:46
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am curious about whether the unit tests run, but I don't consider that a blocker if they are broken.

@brianbolt brianbolt merged commit e057bdc into brianbolt/issue300 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants