Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spring and hibernate Brianbolt/issue300 #302

Merged
merged 82 commits into from
May 4, 2022

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Apr 5, 2022

Description

  • Upgraded dependencies
    • Spring 5.3.19
    • Hibernate
    • Spring Security
  • Implemented custom http firewall to allow // urls through as many ACAS routes have them
  • Implemented custom hibernate.physical_naming_strategy
    • Our old setting which mapped Entities via camel casing no longer works in hibernate 5

Related Issue

Fixes #300

How Has This Been Tested?

  • Logged in via the UI
  • Registered a compound
  • Loaded a file
  • Ran ACAS client tests pass

@brianbolt brianbolt requested a review from bffrost April 5, 2022 22:45
@brianbolt brianbolt changed the title Brianbolt/issue300 Update spring and hibernate Brianbolt/issue300 Apr 5, 2022
@brianbolt brianbolt marked this pull request as draft April 5, 2022 23:05
Copy link
Contributor Author

@brianbolt brianbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bunch of comments. I'd read over them first. There are lots of files changes but the types of changes are empirically low.

Note also the changes to applicationSecurity-context.xml need to be propagated to deployments which customize this file.

Dockerfile-multistage Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
src/main/resources/META-INF/persistence.xml Show resolved Hide resolved
src/main/resources/log4j2.xml Show resolved Hide resolved
@brianbolt
Copy link
Contributor Author

@philippcheung @jmcneil86043 Just a heads up that this is coming down the pike. It's a pretty big change to the base persistence layer of ACAS so wanted to give you a heads up. Still a draft but one thing that I know is broken is the ROO UI. Use of the ROO UI has been waining for years in favor of making proper node admin modules so we aren't inclined to spend a bunch of effort to fix it but if its easy, then we will.

brianbolt and others added 28 commits April 28, 2022 18:12
Organize all imports, format and remove unused roo generated api methods
@brianbolt brianbolt marked this pull request as ready for review May 4, 2022 18:35
@brianbolt brianbolt merged commit e7bde99 into release/1.13.7 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring/Hibernate upgrades
3 participants