Fix unreadable text in light theme and improve accessiblity #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckn
approved these changes
Oct 4, 2024
|
Fixes #40 |
|
Hello, I've just upgraded to 1.1.2, but my my funnel is a bit strange:
It might be my mistake, but the lowest value is not displayed properly. By the way: I use another funnel on the same dashboard without any issues. The one with this strange behaviour has a lots of transformations, but I think it has nothing to do with this bug. Thank you and Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 commits to fix readability issue and match Grafana accessibility guidelines.
1st commit fix inconsistent text color:
2nd commit fix text color of end of funnel:
This last commit doesn't fix problems introduced by first commit. This was also happening before first commit on light mode.
Let me know if these changes suits you, I'm can make change if needed!
Have a nice day!