Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Remove CSS classes to position image #919

Merged
merged 20 commits into from
Dec 4, 2024

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Dec 4, 2024

Description

@stichbury - could you take a look at the docs changes for me? 🙏

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-12-04 16:39:22 UTC
Commit: c37c2ae

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen huong-li-nguyen self-assigned this Dec 4, 2024
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one query @huong-li-nguyen

I'm seeing a warning in Py.Cafe for the second example: https://vizro--919.org.readthedocs.build/en/919/pages/tutorials/explore-components/#22-add-further-components in the built docs:

Using the title argument in your Plotly chart function may cause misalignment with other component titles on the screen. To ensure consistent alignment, consider using vm.Graph(title='Title', ...).

This isn't code you've changed, but would you mind checking if this is anything that we need to remedy please?

Otherwise, changes LGTM 🏆 🥇

@huong-li-nguyen
Copy link
Contributor Author

huong-li-nguyen commented Dec 4, 2024

This isn't code you've changed, but would you mind checking if this is anything that we need to remedy please?

Fixed :) Not sure why we had the argument title="" in there, because there is not title by default 🤔 Anyway, in case we do add a title to a chart we would do it like this now: vm.Graph(title="XXX", figure=px.box(...)) instead of this vm.Graph(figure=px.box(title="XXX"))

If someone uses the second approach, a warning will be raised as the titles might be misaligned with other components

@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) December 4, 2024 15:52
@huong-li-nguyen huong-li-nguyen merged commit 66413e9 into main Dec 4, 2024
36 checks passed
@huong-li-nguyen huong-li-nguyen deleted the tidy/remove-custom-img-css branch December 4, 2024 16:47
nadijagraca pushed a commit that referenced this pull request Dec 6, 2024
Co-authored-by: Antony Milne <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants