-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Remove CSS classes to position image #919
Conversation
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2024-12-04 16:39:22 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
for more information, see https://pre-commit.ci
vizro-core/changelog.d/20241204_135618_huong_li_nguyen_remove_custom_img_css.md
Outdated
Show resolved
Hide resolved
…custom_img_css.md Co-authored-by: Antony Milne <[email protected]>
…sey/vizro into tidy/remove-custom-img-css
for more information, see https://pre-commit.ci
…sey/vizro into tidy/remove-custom-img-css
for more information, see https://pre-commit.ci
…sey/vizro into tidy/remove-custom-img-css
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one query @huong-li-nguyen
I'm seeing a warning in Py.Cafe for the second example: https://vizro--919.org.readthedocs.build/en/919/pages/tutorials/explore-components/#22-add-further-components in the built docs:
Using the
title
argument in your Plotly chart function may cause misalignment with other component titles on the screen. To ensure consistent alignment, consider usingvm.Graph(title='Title', ...)
.
This isn't code you've changed, but would you mind checking if this is anything that we need to remedy please?
Otherwise, changes LGTM 🏆 🥇
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
for more information, see https://pre-commit.ci
…sey/vizro into tidy/remove-custom-img-css
Fixed :) Not sure why we had the argument If someone uses the second approach, a warning will be raised as the titles might be misaligned with other components |
Co-authored-by: Antony Milne <[email protected]> Co-authored-by: Jo Stichbury <[email protected]>
Description
@stichbury - could you take a look at the docs changes for me? 🙏
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":