Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Some actions stuff... #913

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

antonymilne
Copy link
Contributor

Description

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-12-06 21:33:33 UTC
Commit: 21d705c

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

antonymilne and others added 10 commits December 4, 2024 10:43
…meters, filter_interaction arguments instead of **inputs
…tion class like built-in ones or use shortcut @capture_new_action method. Current issues:

* export_data and filter_interaction are public so still need to work using old method. This is why QA tests are failing. Need to make new_export_data that does it new way and keep old one for legacy?
* have some good ideas for how to handle inputs of custom action but not sure how to handle outputs - ideas given in _action.py and app.py

PR #911 was nearly there and first commits on this branch were tidying that, but then realised that pydantic model is probably better than CapturedCallable (see paper notes) so tried this new approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant