-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Some actions stuff... #913
Draft
antonymilne
wants to merge
11
commits into
main
Choose a base branch
from
tidy/action-to-class-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2024-12-06 21:33:33 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
This reverts commit 2ec1864.
… try another approach" This reverts commit cb27593.
…meters, filter_interaction arguments instead of **inputs
for more information, see https://pre-commit.ci
…tion class like built-in ones or use shortcut @capture_new_action method. Current issues: * export_data and filter_interaction are public so still need to work using old method. This is why QA tests are failing. Need to make new_export_data that does it new way and keep old one for legacy? * have some good ideas for how to handle inputs of custom action but not sure how to handle outputs - ideas given in _action.py and app.py PR #911 was nearly there and first commits on this branch were tidying that, but then realised that pydantic model is probably better than CapturedCallable (see paper notes) so tried this new approach.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":