-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Button as ControlType #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we have significantly extended our API, we should probably add this new type tp our user guides! It may duplicate our actions, but maybe we can find a good way to do so
Hmm.. I see your point but we would essentially duplicate our user guide on the Button (that is currently living under components) under controls as well. We could add in a section under controls and then link to the content in components? Just pushed that change - let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see that ControlType supports vm.Button.
I left one comment, but other than that, the PR looks good!
Closing due to decision to not add Button as an officially supported ControlType and instead go via the route of custom components such that the user can add the Button as a ControlType themselves via |
Description
Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":