-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Open ViViVo links outside iframe #845
Conversation
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2024-11-13 10:00:55 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
Surprisingly this fix doesn't actually work. So it's blocked pending https://discuss.huggingface.co/t/allow-navigation-outside-iframe/114755/2. |
I've raised the issue on the HF discord also but realistically don't expect them to change anything here, so until we hear otherwise the solution is just to open all these links in a new tab with FYI @nadijagraca @huong-li-nguyen this is what I mentioned yesterday at standup. |
HF have said they won't change the settings here so we must continue to open them in a new tab. |
Description
@Joseph-Perkins noticed that if you open up ViViVo on HF in an iframe then the links to github don't work. The reason for this is
https://stackoverflow.com/questions/7649361/github-gist-page-wont-load-in-iframe. The solution is to open these links with
target="_top"
to escape the iframetarget="_blank"
.Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":