Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test interdependence #84

Merged
merged 14 commits into from
Oct 2, 2023
Merged

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Oct 1, 2023

Description

  • Fix unit test interdependence caused by dash.page_registry not being cleaned up after dashboard.build
    • Replace app.build with dashboard.build in unit tests for Accordion / Navigation /Dashboard
    • Add unit test test_page_build_left_side_removed (could previously not be added due to interdependence)
  • Refactor Accordion model (as part of an investigation on whether we can get rid of the dashboard.build dependence)

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@huong-li-nguyen huong-li-nguyen added Bug Report 🐛 Issue contains a bug report Component: Tests 🧪 and removed Bug Report 🐛 Issue contains a bug report labels Oct 1, 2023
@huong-li-nguyen huong-li-nguyen self-assigned this Oct 1, 2023
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review October 2, 2023 07:09
@petar-qb petar-qb self-requested a review October 2, 2023 07:25
maxschulz-COL
maxschulz-COL previously approved these changes Oct 2, 2023
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for tackling this

petar-qb
petar-qb previously approved these changes Oct 2, 2023
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the refactored code. It's so easy to read and understand now.

vizro-core/src/vizro/models/_navigation/_accordion.py Outdated Show resolved Hide resolved
vizro-core/src/vizro/models/_navigation/_accordion.py Outdated Show resolved Hide resolved
@huong-li-nguyen huong-li-nguyen dismissed stale reviews from petar-qb and maxschulz-COL via cb8b448 October 2, 2023 09:19
maxschulz-COL
maxschulz-COL previously approved these changes Oct 2, 2023
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new idea of moving it to the validator, this improved the code readibility a lot! And we can remove the registry access in one place only if we ever want to

petar-qb
petar-qb previously approved these changes Oct 2, 2023
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shared a little note here, but feel free to overlook it and go ahead with the merge if it doesn't quite resonate with you 😄.

@huong-li-nguyen huong-li-nguyen merged commit 320eb28 into main Oct 2, 2023
18 checks passed
@huong-li-nguyen huong-li-nguyen deleted the bug/fix_test_interdependence branch October 2, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants