[Fix] Windows paths #837
Merged
[Fix] Windows paths #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2024-10-29 21:34:03 UTC Link: vizro-core/examples/dev/ |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
antonymilne
commented
Oct 29, 2024
Comment on lines
+130
to
+133
| env: | ||
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
| OPENAI_API_BASE: ${{ secrets.OPENAI_API_BASE }} | ||
| VIZRO_TYPE: pypi |
There was a problem hiding this comment.
FYI @l0uden this is a better way to define environment variables in GHA because it works on all OS.
antonymilne
commented
Oct 29, 2024
Comment on lines
+137
to
+138
| hatch run ${{ matrix.config.hatch-env }}:pip install ../vizro-core | ||
| hatch run ${{ matrix.config.hatch-env }}:test-integration |
There was a problem hiding this comment.
FYI @l0uden I tidied this up by just installing vizro-core directly - no need to build it first.
antonymilne
requested review from
Joseph-Perkins,
huong-li-nguyen,
maxschulz-COL and
lingyielia
as code owners
petar-qb
approved these changes
Oct 29, 2024
maxschulz-COL
approved these changes
Oct 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #836.
I removed our Windows tests nearly a year ago in #192. This was a great idea until something just broke on Windows and we didn't realise...
The Windows tests are much slower than Linux and still quite low value since there are very few things that could break on Windows without breaking it on Linux too. So we run these Windows tests only on merge to main.
The fix here was very straightforward but getting it to work on GitHub actions very painful 😬
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":