-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Remove examples section and point through to gallery #814
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@antonymilne so this is an example of where it's flagging that I need a changelog despite only modifying docs. Presumably it's |
I think it's because you change the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! Looks good, but I have a few comments and questions that I'd like @maxschulz-COL to consider before we merge.
For the link opening in a new window vs. current one: I think this is fine how it is, since generally speaking we should prefer to open in the same tab. On the homepage we could replace the markdown link with an HTML one that includes "opens in new page" icon, but I don't think this would look good on the top bar of the navigation. So tbh I'd just leave it how you have it.
As for the changelog being needed: as you and Li said, this is because you modified mkdocs.yml that lives outside the docs. We could put this in so it's treated as part of the docs, but now that I think about it again I actually think we should change the logic so that a changelog is required for only changes to src
. So docs and everything else outside src
would all be excluded rather than mkdocs.yml
being a special exclusion. wdyt @maxschulz-COL>? My reasoning is:
- changelogs are really only required when there's a change to the package that affects users, which necessarily means changing code in
src
- in case there's some edge cases (e.g. dropping a Python version), you can just manually add a changelog
Overall I think this will be a slightly smoother process since a changelog would only be demanded when it might be needed.
Co-authored-by: Antony Milne <[email protected]>
Co-authored-by: Antony Milne <[email protected]>
I think that is fine, let's go for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! I like it more now, highlights our examples page more, and hyou can still get to user examples quickly
Co-authored-by: Maximilian Schulz <[email protected]>
Description
Build version of PR is here
Discussed here: #629
(Internal ticket #1205
your-examples.md
to the explanation sectionScreenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":