-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce coverage settings and failure threshold #63
Conversation
How do you mean that "Taking out tests from coverage" dilutes the true coverage? Running
gives me same results:
as when I run
|
First there was a small typo in my code, which is now fixed, but now you can see the difference if you take out the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
pyproject.toml
(they weren't doing anything before)Note
However, it was interesting to see that some tests seem to not be executed (when running coverage on test files as well), this needs further investigation (created a ticket)
Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":