-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Remove dashboard related content before code release #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per our chat
Noted on Slack, but I think we should avoid rolling back these changes as there was quite a bit of re-org and rewording in the docs and not just the addition of these two files. I have an outstanding task to also clean up the structure of the Vizro-AI docs and I fear it could all get a bit complex (my poor 🧠 won't handle it). Could we instead focus on making sure the links readers follow are typically going to the latest "stable" (ie released) docs as we intended. The way to do this:
|
Hey, independently of you I took a stab, slightly different strategy, I tried to replace all links to latest with https://vizro-ai.readthedocs.io/ as that seems the safest option? See this PR: #623 The 5 links which I could not replace are shown below, they refer to specific sections, where we would need @stichbury Any objects to merge this PR quickly? |
I have no objections to hardcoded I think we're agreed with the other and you're flipping your changes. Thanks for doing this so swiftly! Ping me on Slack and I'll approve so you can merge ASAP. |
Description
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":