-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix inconsistent return types in selector values #562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Li! I agree with should follow Dash default in this case. Approved with 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work all round @GiulioMorinaQB for the great bug report and @lingyielia and @huong-li-nguyen for the very speedy temporary and permanent fix! 💯
Just to check: @huong-li-nguyen does the new test fail before your fix?
vizro-core/changelog.d/20240703_091955_huong_li_nguyen_fix_selector_return_type.md
Outdated
Show resolved
Hide resolved
Yes, of course! That's how I checked that the test was working 😄 |
Description
Previously if you've specified the options of a selector as a
List[Dict]
inside aParameter
, the value was returned as a List[Dict] when "ALL" was selected (introduced by us), but would return a List of values only when selecting other values from the multi selector (dash default). This could lead to issues when using custom charts, as it's not immediately transparent for the user what the return type is, see #557.FYI: @lingyielia @petar-qb @antonymilne
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":