-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move update of graph theme to Graph.__call__
#174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antony Milne <[email protected]>
antonymilne
requested review from
Joseph-Perkins,
huong-li-nguyen,
maxschulz-COL and
lingyielia
as code owners
November 15, 2023 10:31
antonymilne
changed the title
Tidy/update graph theme
Move update of graph theme to Nov 15, 2023
Graph.__call__
antonymilne
commented
Nov 15, 2023
vizro-core/src/vizro/actions/_callback_mapping/_callback_mapping_utils.py
Show resolved
Hide resolved
antonymilne
commented
Nov 15, 2023
petar-qb
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tidying up! 🚀
vizro-core/src/vizro/actions/_callback_mapping/_callback_mapping_utils.py
Show resolved
Hide resolved
Joseph-Perkins
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As prototyped in #166, a bit of further refactoring with no change in functionality.
Before: the code to update graph theme lived in
_callback_mapping_utils.py
.Now: it lives in
Graph
, plus a couple of other improvements.Why is this (probably) better?
ctd_theme
Graph
implementationupdate_graph_theme
callback and theupdate_layout
call is centralised to a singleGraph._update_theme
methodupdate_theme
callback is generic so in theory works for components other thanGraph
so long as they define a_update_theme
method (probably not very useful in practice)Possible drawbacks:
Graph.__call__
is coupled to the Dash callback context. This was actually aways my original intention, but it was never made explicit before, and the current actions implementation works somewhat differently. To be seen whether it causes problemsFuture work:
_update_theme
call inGraph.__call__
altogether by makingupdate_theme
a clientside callback. This would be even nicer, but the current solution is perfectly performant so it's not a big problem__call__
Checklist
Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":