-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release process for Vizro AI #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxschulz-COL
requested review from
Joseph-Perkins,
antonymilne and
huong-li-nguyen
as code owners
November 10, 2023 18:43
maxschulz-COL
added
Vizro-AI 🤖
Issue/PR that addresses Vizro-AI package
Status: Ready for Review ☑️
labels
Nov 10, 2023
antonymilne
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of very minor suggestions but looks good I think! @lingyielia please could you take a look at my suggestions, accept if you agree with them and review? 🙏
antonymilne
reviewed
Nov 13, 2023
l0uden
reviewed
Nov 13, 2023
lingyielia
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the release process for Vizro-AI
Any future release of the package follow the exact same pattern as
vizro-core
, ie it should in principle (after some likely initial bumps) only require one command from the root of the package:hatch run prep-release
Screenshot
Checklist
Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":