-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy schema linting #136
Tidy schema linting #136
Conversation
Signed-off-by: Antony Milne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, looks good to me 👍
Have we been testing this out? I remember Max previously merging 2-3 PRs on fixing the linting behaviour during the release process, because somehow it didn't behave the way we wanted it to 😄 I remember that double linting call was somehow required? @maxschulz-COL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing those 💪 Should work as intended, else we have to adjust again :)
In principle with this change the linting should not be required at all, so also no double linting should be required. Given that we can always lint manually I would just test this out, and adjust in case this fails for some reason.. |
Description
Just a small tidy following @maxschulz-COL's work in #119.
hatch run schema
will now include linting so no need to runhatch run lint
manually after that.hatch run lint
with no other arguments still lints all files (not just staged files)hatch run lint --file=...
to just lint some fileslint
Checklist
Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":