Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy schema linting #136

Merged
merged 13 commits into from
Nov 2, 2023
Merged

Tidy schema linting #136

merged 13 commits into from
Nov 2, 2023

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented Oct 31, 2023

Description

Just a small tidy following @maxschulz-COL's work in #119.

  • hatch run schema will now include linting so no need to run hatch run lint manually after that.
  • hatch run lint with no other arguments still lints all files (not just staged files)
  • you can change this by overriding arguments e.g. hatch run lint --file=... to just lint some files
  • Create a detached linting environment called lint

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@antonymilne antonymilne enabled auto-merge (squash) October 31, 2023 09:52
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good to me 👍

Have we been testing this out? I remember Max previously merging 2-3 PRs on fixing the linting behaviour during the release process, because somehow it didn't behave the way we wanted it to 😄 I remember that double linting call was somehow required? @maxschulz-COL

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing those 💪 Should work as intended, else we have to adjust again :)

@maxschulz-COL
Copy link
Contributor

In general, looks good to me 👍

Have we been testing this out? I remember Max previously merging 2-3 PRs on fixing the linting behaviour during the release process, because somehow it didn't behave the way we wanted it to 😄 I remember that double linting call was somehow required? @maxschulz-COL

In principle with this change the linting should not be required at all, so also no double linting should be required. Given that we can always lint manually I would just test this out, and adjust in case this fails for some reason..

@antonymilne antonymilne disabled auto-merge November 1, 2023 12:26
@maxschulz-COL maxschulz-COL enabled auto-merge (squash) November 2, 2023 15:40
@maxschulz-COL maxschulz-COL merged commit b81139b into main Nov 2, 2023
20 checks passed
@maxschulz-COL maxschulz-COL deleted the tidy/schema-linting branch November 2, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants